Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use provider config options with default configs #240

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Use provider config options with default configs #240

merged 2 commits into from
Jun 14, 2024

Conversation

eemcmullan
Copy link
Collaborator

Closes #199

@eemcmullan eemcmullan force-pushed the custom-config branch 4 times, most recently from 94d2fab to a125287 Compare May 22, 2024 20:25
@eemcmullan eemcmullan marked this pull request as ready for review May 22, 2024 20:26
@eemcmullan eemcmullan requested review from pranavgaikwad and aufi May 22, 2024 20:44
aufi
aufi approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eemcmullan eemcmullan changed the title Use provider config options with default config options Use provider config options with default configs May 23, 2024
pranavgaikwad
pranavgaikwad reviewed May 30, 2024
View reviewed changes
cmd/analyze.go Outdated Show resolved Hide resolved
pranavgaikwad
pranavgaikwad reviewed May 30, 2024
View reviewed changes
Copy link
Contributor

@pranavgaikwad pranavgaikwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets keep maven settings file option for now

@eemcmullan eemcmullan requested a review from pranavgaikwad May 30, 2024 19:51
pranavgaikwad
pranavgaikwad reviewed Jun 11, 2024
View reviewed changes
cmd/analyze.go Outdated Show resolved Hide resolved
shawn-hurley
shawn-hurley reviewed Jun 12, 2024
View reviewed changes
cmd/analyze.go Outdated Show resolved Hide resolved
shawn-hurley
shawn-hurley reviewed Jun 12, 2024
View reviewed changes
Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, I think this is going to be an excellent user experience!

cmd/analyze.go Show resolved Hide resolved
cmd/analyze.go Show resolved Hide resolved
shawn-hurley
shawn-hurley approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the complexity nit LGTM

@eemcmullan eemcmullan merged commit 144a657 into konveyor:main Jun 14, 2024
3 checks passed
@eemcmullan eemcmullan deleted the custom-config branch August 27, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aufi aufi aufi approved these changes

@shawn-hurley shawn-hurley shawn-hurley approved these changes

@pranavgaikwad pranavgaikwad Awaiting requested review from pranavgaikwad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use providerSettings config to pass provider options
4 participants
@eemcmullan @aufi @shawn-hurley @pranavgaikwad