🐛 handle incident uri on windows #338
Conversation
|
@abrugaro I believe what is happening is that the path-browserify doesn't attempt to handle windows paths at all so our regex breaks on paths with |
There was a problem hiding this comment.
Feels like the basic function that does "take the workspace root Uri and the file Uri and produce a file path that is the relative path from workspace root to the file" needs to be moved to a file under webview-ui/src/utils so we can actually setup some unit tests on it to make sure it works under different permutations.
djzager
force-pushed
the
incidents-on-windows
branch
from
c6b0358 to
5e4f353
Compare
Enable mocha tests on `webview-ui` by: - moving mocha deps to root `package.json` - adding `.mocharc.json` to each project that has unit tests - adopt `tsx` instead of `ts-node` Note: A glob is in place on `webview-ui`'s test script since no unit test currently exist to run. In that case, it isn't really an error. In the future, once a test is added, the glob check should be removed so mocha will fail if tests are not found. Supports: konveyor#338 Signed-off-by: Scott J Dickerson <[email protected]>
Enable mocha tests on `webview-ui` by: - moving mocha deps to root `package.json` - adding `.mocharc.json` to each project that has unit tests - adopt `tsx` instead of `ts-node` Note: A glob is in place on `webview-ui`'s test script since no unit test currently exist to run. In that case, it isn't really an error. In the future, once a test is added, the glob check should be removed so mocha will fail if tests are not found. Supports: konveyor#338 Signed-off-by: Scott J Dickerson <[email protected]>
Enable mocha tests on `webview-ui` by: - moving mocha deps to root `package.json` - adding `.mocharc.json` to each project that has unit tests - adopt `tsx` instead of `ts-node` Note: A glob is in place on `webview-ui`'s test script since no unit test currently exist to run. In that case, it isn't really an error. In the future, once a test is added, the glob check should be removed so mocha will fail if tests are not found. Supports: #338 Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: David Zager <[email protected]>
djzager
force-pushed
the
incidents-on-windows
branch
from
c7f7270 to
c2b0bdb
Compare
|
Ugh so my fancy glob command on the test script also lets things pass when the tests actually fail: Feel free to change the |
Thank you for noticing that. I was said that the tests didn't fail 😁 |
Fixes #252