Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Rewording notfication for better user experience #304

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

hhpatel14
Copy link
Contributor

No incidents were detected in this file after reanalysis. It seems the issue has been resolved or is no longer relevant. Rewording notification for clarity.
Screenshot 2025-01-27 at 1 09 31 PM

@hhpatel14 hhpatel14 requested a review from a team as a code owner January 28, 2025 14:30
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs DCO.

Suggested change in the wording.

lint-staged should clean up the formatting warning on git commit. Just make sure you npm install on the repo so it is activated.

vscode/src/client/analyzerClient.ts Outdated Show resolved Hide resolved
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjd78 sjd78 merged commit f5e837a into konveyor:main Feb 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants