🐛 Ensure konveyor file system resources are resolved during session restore #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resolved during session restore Signed-off-by: Ian Bolton <[email protected]>
ibolton336
force-pushed
the
memfs-initialization
branch
from
2d3fc78 to
ce3a2bd
Compare
ibolton336
changed the title
djzager
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #185
When a user closes VS Code with open tabs that reference resources from our custom file system (konveyorMemFs or konveyorReadOnly), those tabs fail to load on the next startup. This is because our extension does not activate automatically on VS Code startup or when restoring those resources. Instead, the extension only activates when the user interacts with the sidebar, leading to errors such as:
"The editor could not be opened due to an unexpected error: Unable to resolve resource konveyorReadOnly:/path/to/resource"
Fix:
We added activationEvents to package.json to ensure the extension activates automatically when resources using our custom schemes (konveyorMemFs and konveyorReadOnly) are accessed. This ensures that the file system provider is registered and available before VS Code attempts to restore such resources.