Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Use violation id instead of description for key #236

Merged
merged 4 commits into from
Jan 24, 2025
Merged

🐛 Use violation id instead of description for key #236

merged 4 commits into from
Jan 24, 2025

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Jan 21, 2025 •
edited
Loading

Resolves #229
Resolves #277

  • Create intersection type ViolationWithID for using data structure driven ID for key
  • Removes unused types

@ibolton336 ibolton336 requested a review from a team as a code owner January 21, 2025 20:49
@ibolton336 ibolton336 marked this pull request as draft January 21, 2025 21:49
@ibolton336 ibolton336 marked this pull request as ready for review January 21, 2025 22:06
@rszwajko rszwajko mentioned this pull request Jan 23, 2025
Open
@ibolton336 ibolton336 merged commit 3d7639c into konveyor:main Jan 24, 2025
9 checks passed
@rszwajko rszwajko mentioned this pull request Jan 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djzager djzager djzager approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ibolton336 @djzager