-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Resolution page v2 #204
✨ Resolution page v2 #204
Conversation
ae4fa26
to
614b724
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really awesome to see! Nice work.
The only issue I see is in Dark Mode, the white text on blue label is hard to read. I'm not sure if the right way to fix it is to change what "blue" is in dark mode, or to change the color on the label when in dark mode.
yep. check the latest commit - I've switched to black. |
@sjd78 @ibolton336
|
Changes: 1. show Resolutions page from Issue tree view via conext button 2. track solution state and collect log messages 3. use chat-like layout Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
b123a06
to
54965b7
Compare
Force pushed to rebase on top of current HEAD. |
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The screen shots look pretty good. I expect some followup tweaking as it gets more use, but it is a solid base. Code structure is reasonable. I only found one lingering console.log that could be kept if it makes sense.
Fighting to get the vscode themes to line up with PF6 styles will be ongoing. Looks a good at least 90% of the way there and that feels good enough at this point.
Changes:
Part of: #171
Resolves: #176
Resolves: #181
Resolves: #178