Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Resolution page v2 #204

Merged
merged 8 commits into from
Jan 21, 2025
Merged

✨ Resolution page v2 #204

merged 8 commits into from
Jan 21, 2025

Conversation

rszwajko
Copy link
Contributor

@rszwajko rszwajko commented Jan 16, 2025

Changes:

  1. show Resolutions page from Issue tree view via conext button
  2. track solution state and collect log messages
  3. use chat-like layout
  4. support Markdown
  5. support light/dark mode

Part of: #171
Resolves: #176
Resolves: #181
Resolves: #178

@rszwajko
Copy link
Contributor Author

Resolution page in light mode

Screenshot from 2025-01-16 23-54-15
Screenshot from 2025-01-17 00-04-27

Analysis page in light mode with markdown

Screenshot from 2025-01-16 23-53-38

Resolution page in dark mode

Screenshot from 2025-01-17 00-08-05

Opening Resolution page from Issue tree view

Screenshot from 2025-01-17 00-08-34

@rszwajko rszwajko marked this pull request as ready for review January 17, 2025 09:38
@rszwajko rszwajko requested a review from a team as a code owner January 17, 2025 09:38
@rszwajko
Copy link
Contributor Author

Updated styles for file changes

Screenshot from 2025-01-17 15-14-33
Screenshot from 2025-01-17 15-14-06

Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really awesome to see! Nice work.

The only issue I see is in Dark Mode, the white text on blue label is hard to read. I'm not sure if the right way to fix it is to change what "blue" is in dark mode, or to change the color on the label when in dark mode.

@rszwajko
Copy link
Contributor Author

@djzager

The only issue I see is in Dark Mode, the white text on blue label is hard to read

yep. check the latest commit - I've switched to black.

@ibolton336
Copy link
Member

ibolton336 commented Jan 20, 2025

Noticing an issue with styling. A new media query that adds spacing for a sidebar in the page component is added maybe by the pf virtual assistant library.

Screenshot 2025-01-20 at 12 50 18 PM

The page component is no longer center aligned and a large space to left is visible when viewing analysis results. Seems related to a media query affecting the width of the page component.

Was able to find a fix:

  • In App.tsx, add in the App.css import.
  • Remove the existing stale css in app.css and replace with:
@media (min-width: 75rem) {
  .pf-v6-c-page {
    grid-template-columns: 1fr !important;
    grid-template-areas: 
      "header"
      "main";
  }
}

@rszwajko
Copy link
Contributor Author

rszwajko commented Jan 20, 2025

@sjd78 @ibolton336
The layout problems seems related to missing sidebar - after providing a dummy hidden sidebar it looks OK without any tweaks.
Additionally in the latest commit:

  1. I've fixed double scrollbars by moving "Run analysis" button to the masthead and removing manual height calculation.
  2. Removed "Cancel" button as suggested in Canceling fix generation doesn't do anything #178

@rszwajko
Copy link
Contributor Author

Scrollbars and buttons in the masthead

Screenshot from 2025-01-20 22-59-50
Screenshot from 2025-01-20 22-55-06

Changes:
1. show Resolutions page from Issue tree view via conext button
2. track solution state and collect log messages
3. use chat-like layout

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
@rszwajko
Copy link
Contributor Author

Force pushed to rebase on top of current HEAD.

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screen shots look pretty good. I expect some followup tweaking as it gets more use, but it is a solid base. Code structure is reasonable. I only found one lingering console.log that could be kept if it makes sense.

Fighting to get the vscode themes to line up with PF6 styles will be ongoing. Looks a good at least 90% of the way there and that feels good enough at this point.

webview-ui/src/components/ResolutionsPage.tsx Show resolved Hide resolved
@rszwajko rszwajko merged commit d45186c into konveyor:main Jan 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants