Canceling fix generation doesn't do anything

[pranavgaikwad]

When you press the Cancel button when generating a fix, nothing happens.

[sjd78]

Some analysis

This button is display on the "Konveyor Analysis View". The webview will send a CANCEL_SOLUTION webview messages, but the message in not current handled in the extension (vscode/src/webviewMessageHandler.ts).

The message will need to be implemented.

The getSolution implementation doesn't currently include an abort signal / option:

editor-extensions/vscode/src/client/analyzerClient.ts

Lines 486 to 543 in 6bdca4c

	/**
	* Request the server to __getCodeplanAgentSolution__
	*
	* Will only run if the sever state is: `running`
	*/
	public async getSolution(
	state: ExtensionState,
	incident: Incident,
	violation: Violation,
	): Promise<void> {
	// TODO: Ensure serverState is running
	if (!this.rpcConnection) {
	vscode.window.showErrorMessage("RPC connection is not established.");
	return;
	}
	this.fireSolutionStateChange(true);
	const enhancedIncident = {
	...incident,
	ruleset_name: violation.category || "default_ruleset",
	violation_name: violation.description || "default_violation",
	};
	const maxPriority = getConfigMaxPriority();
	const maxDepth = getConfigMaxDepth();
	const maxIterations = getConfigMaxIterations();
	try {
	const request = {
	file_path: "",
	incidents: [enhancedIncident],
	max_priority: maxPriority,
	max_depth: maxDepth,
	max_iterations: maxIterations,
	};
	this.outputChannel.appendLine(
	`getCodeplanAgentSolution request: ${JSON.stringify(request, null, 2)}`,
	);
	const response: SolutionResponse = await this.rpcConnection!.sendRequest(
	"getCodeplanAgentSolution",
	request,
	);
	vscode.commands.executeCommand("konveyor.loadSolution", response, {
	incident,
	violation,
	});
	} catch (err: any) {
	this.outputChannel.appendLine(`Error during getSolution: ${err.message}`);
	vscode.window.showErrorMessage("Get solution failed. See the output channel for details.");
	}
	this.fireSolutionStateChange(false);
	}

Proper fix

Fixing this properly would require implementing #149 (which would require konveyor/kai#525)

For now

Simply remove the Cancel button all together until #149 is working.