Fix asset for manually added non-steam games #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I said here : SteamGridDB#130, SteamGridDB don't update assets for non-steam games added manually (non imported by SteamGridDB). After researches I found that Steam generate an random individual ID for every non-steam game manually added and it doesn't correspond to the function generateNewAppId used here, It results that SteamGridDB update images with the wrong ID's My commit set the value of appid with generateNewAppID only if there's no existing appid so it works with imported and manually added non-steam games.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I said here : SteamGridDB#130, SteamGridDB don't update assets for non-steam games added manually (non imported by SteamGridDB).
After researches I found that Steam generate an random individual ID for every non-steam game manually added and it doesn't correspond to the function generateNewAppId used here,
It results that SteamGridDB update images with the wrong ID's
My commit set the value of appid with generateNewAppID only if there's no existing appid so it works with imported and manually added non-steam games.