http_listener_v2: make http header tags case insensitive (influxdata#…

…7986)
komodorio · Aug 14, 2020 · b2eb774 · b2eb774
1 parent b8b6f2e
commit b2eb774
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/plugins/inputs/http_listener_v2/http_listener_v2.go b/plugins/inputs/http_listener_v2/http_listener_v2.go
@@ -232,9 +232,9 @@ func (h *HTTPListenerV2) serveWrite(res http.ResponseWriter, req *http.Request)
 
 	for _, m := range metrics {
 		for headerName, measurementName := range h.HTTPHeaderTags {
-			headerValues, foundHeader := req.Header[headerName]
-			if foundHeader && len(headerValues) > 0 {
-				m.AddTag(measurementName, headerValues[0])
+			headerValues := req.Header.Get(headerName)
+			if len(headerValues) > 0 {
+				m.AddTag(measurementName, headerValues)
 			}
 		}
 

diff --git a/plugins/inputs/http_listener_v2/http_listener_v2_test.go b/plugins/inputs/http_listener_v2/http_listener_v2_test.go
@@ -383,7 +383,7 @@ func TestWriteHTTPEmpty(t *testing.T) {
 
 func TestWriteHTTPTransformHeaderValuesToTagsSingleWrite(t *testing.T) {
 	listener := newTestHTTPListenerV2()
-	listener.HTTPHeaderTags = map[string]string{"Present_http_header_1": "presentMeasurementKey1", "Present_http_header_2": "presentMeasurementKey2", "NOT_PRESENT_HEADER": "notPresentMeasurementKey"}
+	listener.HTTPHeaderTags = map[string]string{"Present_http_header_1": "presentMeasurementKey1", "present_http_header_2": "presentMeasurementKey2", "NOT_PRESENT_HEADER": "notPresentMeasurementKey"}
 
 	acc := &testutil.Accumulator{}
 	require.NoError(t, listener.Start(acc))

diff --git a/testutil/log.go b/testutil/log.go
@@ -2,8 +2,12 @@ package testutil
 
 import (
 	"log"
+
+	"github.com/influxdata/telegraf"
 )
 
+var _ telegraf.Logger = &Logger{}
+
 // Logger defines a logging structure for plugins.
 type Logger struct {
 	Name string // Name is the plugin name, will be printed in the `[]`.