ENH: add less ufunc #150
Open
ENH: add less ufunc #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* draft the `less()` ufunc and turn its array API standard test on in CI * some of the changes here are modified/copied from other recent binary ufunc pull requests, like the broadcasting and type matching machinery; type matching in particular was expanded to include floating types, at least crudely * there are probably some formatting improvements that could be made for some of the ufunc workunits added here--feel free to push those in--some of that work is basically just find/replace in text editor...
tylerjereddy
added
enhancement
tylerjereddy
commented
Jan 8, 2023
| def astype(view, dtype): | ||
| new_view = pk.View([*view.shape], dtype=dtype) | ||
| new_view[:] = view | ||
| return new_view |
There was a problem hiding this comment.
was needed by the array API testing machinery for less()
| def less_impl_5d_int8(tid: int, | ||
| view1: pk.View5D[pk.int8], | ||
| view2: pk.View5D[pk.int8], | ||
| out: pk.View5D[pk.uint8]): |
There was a problem hiding this comment.
column-alignment could be cleaned up--feel free to help me with that... wasn't a high priority of course
| view1_new = pk.View([*view1.shape], dtype=effective_dtype) | ||
| view1_new[:] = view1 | ||
| view1 = view1_new | ||
| return view1, view2, effective_dtype |
There was a problem hiding this comment.
above two functions show up in some of my other binary ufunc branches/PRs, they may be slightly different here to accommodate expanding needs
* handle a few more dtype styles in `_typematch_views()`, which seem to be needed for the array API testsuite to pass with newer versions of `hypothesis`
* use properly sized integer types for `__lt__` comparisons
tylerjereddy
added a commit
to tylerjereddy/pykokkos
that referenced
this pull request
Jan 9, 2023
* adjust the `greater()` ufunc to pass its array API standard test, and turn this test on in the CI * this largely mirrors the changes in kokkosgh-150, except that we already had a draft implementation of `greater()` in place here
tylerjereddy
added a commit
to tylerjereddy/pykokkos
that referenced
this pull request
Jan 12, 2023
* add the `less_equal()` ufunc and turn its array API standard test on in the CI; this is naturally quite similar to kokkosgh-150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft the
less()ufunc and turn its array API standard test on in CIsome of the changes here are modified/copied from other recent binary ufunc pull requests, like the
broadcasting and type matching machinery; type matching in particular was expanded to include floating types, at least crudely
there are probably some formatting improvements that could be made for some of the ufunc workunits added here--feel free to push those in--some of that work is basically just find/replace in text editor...