Skip to content

Commit

Permalink
Merge pull request #141 from koenbeuk/remove-legacy-support
Browse files Browse the repository at this point in the history
Removed V1/V2 support
  • Loading branch information
koenbeuk authored Mar 17, 2022
2 parents 634a441 + f734bb6 commit a402e84
Show file tree
Hide file tree
Showing 169 changed files with 81 additions and 672 deletions.
20 changes: 1 addition & 19 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<LangVersion>9.0</LangVersion>
<Nullable>enable</Nullable>
<EnableNETAnalyzers>true</EnableNETAnalyzers>
<Configurations>Debug;Release;DebugV1;ReleaseV1;DebugV2;ReleaseV2</Configurations>
<Configurations>Debug;Release</Configurations>
</PropertyGroup>

<PropertyGroup>
Expand All @@ -23,22 +23,4 @@
<MicrosoftExtensionsVersion>6.0.0</MicrosoftExtensionsVersion>
</PropertyGroup>

<PropertyGroup Condition=" '$(Configuration)' == 'DebugV2' Or '$(Configuration)' == 'ReleaseV2' ">
<EFCoreTriggeredVersion>2</EFCoreTriggeredVersion>
<EFCorePackageVersion>5.0.0</EFCorePackageVersion>
<MicrosoftExtensionsVersion>5.0.0</MicrosoftExtensionsVersion>
</PropertyGroup>

<PropertyGroup Condition=" '$(Configuration)' == 'DebugV1' Or '$(Configuration)' == 'ReleaseV1' ">
<EFCoreTriggeredVersion>1</EFCoreTriggeredVersion>
<EFCorePackageVersion>3.1.0</EFCorePackageVersion>
<MicrosoftExtensionsVersion>3.1.0</MicrosoftExtensionsVersion>
</PropertyGroup>

<Target Name="Debug">
<Message Importance="High" Text="Configuration: $(Configuration)" />
<Message Importance="High" Text="EFCoreTriggeredVersion: $(EFCoreTriggeredVersion)" />
<Message Importance="High" Text="EFCorePackageVersion: $(EFCorePackageVersion)" />
</Target>

</Project>
10 changes: 4 additions & 6 deletions EntityFrameworkCore.Triggered.Samples.slnf
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,11 @@
"solution": {
"path": "EntityFrameworkCore.Triggered.sln",
"projects": [
"samples\\v1\\1 - HelloWorld\\1 - HelloWorld.csproj",
"samples\\v2\\1 - HelloWorld\\1 - HelloWorld.csproj",
"samples\\v2\\2 - PrimarySchool\\2 - PrimarySchool.csproj",
"samples\\v2\\3 - StudentManagerAspNetCore\\3 - StudentManagerAspNetCore.csproj",
"samples\\v2\\4 - BlazorTests\\4 - BlazorTests.csproj",
"samples\\1 - HelloWorld\\1 - HelloWorld.csproj",
"samples\\2 - PrimarySchool\\2 - PrimarySchool.csproj",
"samples\\3 - StudentManagerAspNetCore\\3 - StudentManagerAspNetCore.csproj",
"samples\\4 - BlazorTests\\4 - BlazorTests.csproj",
"src\\EntityFrameworkCore.Triggered.Abstractions\\EntityFrameworkCore.Triggered.Abstractions.csproj",
"src\\EntityFrameworkCore.Triggered.AspNetCore\\EntityFrameworkCore.Triggered.AspNetCore.csproj",
"src\\EntityFrameworkCore.Triggered.Transactions.Abstractions\\EntityFrameworkCore.Triggered.Transactions.Abstractions.csproj",
"src\\EntityFrameworkCore.Triggered.Transactions\\EntityFrameworkCore.Triggered.Transactions.csproj",
"src\\EntityFrameworkCore.Triggered\\EntityFrameworkCore.Triggered.csproj"
Expand Down
175 changes: 59 additions & 116 deletions EntityFrameworkCore.Triggered.sln

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net5.0</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
<RootNamespace>HelloWorld</RootNamespace>
<Nullable>disable</Nullable>
</PropertyGroup>
Expand Down
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net5.0</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
<RootNamespace>PrimarySchool</RootNamespace>
<Nullable>disable</Nullable>
</PropertyGroup>
Expand Down
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Web">

<PropertyGroup>
<TargetFramework>net5.0</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
<RootNamespace>StudentManager</RootNamespace>
<Nullable>disable</Nullable>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Web">

<PropertyGroup>
<TargetFramework>net5.0</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
<RootNamespace>BlazorTests</RootNamespace>
<Nullable>disable</Nullable>
</PropertyGroup>
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
6 changes: 6 additions & 0 deletions samples/Directory.Build.props
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<Project>
<PropertyGroup>
<EFCorePackageVersion>6.0.0</EFCorePackageVersion>
<EFCoreTriggeredPackageVersion Condition=" '$(EFCoreTriggeredPackageVersion )'=='' ">3.0.0</EFCoreTriggeredPackageVersion>
</PropertyGroup>
</Project>
16 changes: 0 additions & 16 deletions samples/v1/1 - HelloWorld/1 - HelloWorld.csproj

This file was deleted.

31 changes: 0 additions & 31 deletions samples/v1/1 - HelloWorld/ApplicationContext.cs

This file was deleted.

22 changes: 0 additions & 22 deletions samples/v1/1 - HelloWorld/Program.cs

This file was deleted.

6 changes: 0 additions & 6 deletions samples/v1/Directory.Build.props

This file was deleted.

9 changes: 0 additions & 9 deletions samples/v2/1 - HelloWorld/README.MD

This file was deleted.

This file was deleted.

7 changes: 0 additions & 7 deletions samples/v2/Directory.Build.props

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ public static IServiceCollection AddTriggeredDbContextPool<TContext>(this IServi
return serviceCollection;
}

#if EFCORETRIGGERED2 || EFCORETRIGGERED3
public static IServiceCollection AddTriggeredDbContextFactory<TContext>(this IServiceCollection serviceCollection, Action<DbContextOptionsBuilder>? optionsAction = null, ServiceLifetime lifetime = ServiceLifetime.Singleton)
where TContext : DbContext
{
Expand Down Expand Up @@ -127,7 +126,6 @@ public static IServiceCollection AddTriggeredPooledDbContextFactory<TContext>(th

var serviceDescriptor = serviceCollection.FirstOrDefault(x => x.ServiceType == typeof(IDbContextFactory<TContext>));

#if EFCORETRIGGERED2
if (serviceDescriptor?.ImplementationType != null)
{
var triggeredFactoryType = typeof(TriggeredDbContextFactory<,>).MakeGenericType(typeof(TContext), serviceDescriptor.ImplementationType);
Expand All @@ -144,7 +142,7 @@ public static IServiceCollection AddTriggeredPooledDbContextFactory<TContext>(th
lifetime: ServiceLifetime.Scoped
));
}
#elif EFCORETRIGGERED3
if (serviceDescriptor?.ImplementationFactory != null)
{
var triggeredFactoryType = typeof(TriggeredDbContextFactory<>).MakeGenericType(typeof(TContext));
Expand All @@ -155,9 +153,7 @@ public static IServiceCollection AddTriggeredPooledDbContextFactory<TContext>(th
lifetime: ServiceLifetime.Scoped
));
}
#endif
return serviceCollection;
}
#endif
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ public override void PopulateDebugInfo(IDictionary<string, string> debugInfo)
debugInfo["Triggers:CascadeBehavior"] = Extension._cascadeBehavior.ToString();
}

#if EFCORETRIGGERED3
public override int GetServiceProviderHashCode()
{
var hashCode = new HashCode();
Expand Down Expand Up @@ -89,40 +88,6 @@ public override bool ShouldUseSameServiceProvider(DbContextOptionsExtensionInfo
&& Extension._maxCascadeCycles == otherInfo.Extension._maxCascadeCycles
&& Extension._cascadeBehavior == otherInfo.Extension._cascadeBehavior
&& Extension._serviceProviderTransform == otherInfo.Extension._serviceProviderTransform;
#else
public override long GetServiceProviderHashCode()
{
var hashCode = nameof(TriggersOptionExtension).GetHashCode();

var extension = (TriggersOptionExtension)Extension;

if (extension._triggers != null)
{
foreach (var trigger in extension._triggers)
{
hashCode ^= trigger.GetHashCode();
}
}

if (extension._triggerTypes != null)
{
foreach (var triggerType in extension._triggerTypes)
{
hashCode ^= triggerType.GetHashCode();
}
}

hashCode ^= extension._maxCascadeCycles.GetHashCode();
hashCode ^= extension._cascadeBehavior.GetHashCode();

if (extension._serviceProviderTransform != null)
{
hashCode ^= extension._serviceProviderTransform.GetHashCode();
}

return hashCode;
}
#endif
}

private ExtensionInfo? _info;
Expand Down Expand Up @@ -185,10 +150,7 @@ public void ApplyServices(IServiceCollection services)

services.AddScoped<TriggerFactory>();

#if EFCORETRIGGERED2 || EFCORETRIGGERED3
services.TryAddScoped<IInterceptor, TriggerSessionSaveChangesInterceptor>();
#endif


services.Configure<TriggerOptions>(triggerServiceOptions => {
triggerServiceOptions.MaxCascadeCycles = _maxCascadeCycles;
Expand Down
Loading

0 comments on commit a402e84

Please sign in to comment.