Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to dotnet 8 #96

Merged
merged 9 commits into from
Mar 8, 2024
Merged

Updated to dotnet 8 #96

merged 9 commits into from
Mar 8, 2024

Conversation

koenbeuk
Copy link
Owner

No description provided.

@StonedHackerman
Copy link

Hi,
I tested the .NET 8 branch today and everything works flawlessly, fixing issue #95. All the checks passed, will you merge this branch into main or is there more work to be done?

@koenbeuk
Copy link
Owner Author

koenbeuk commented Jan 3, 2024

Thanks for testing it out, I have a few uncommitted test cases that were failing which is delaying the release of this version. I've just been swamped and haven't had a chance to get back to this yet. I will try and prioritize this to get this out of the door asap.

@koenbeuk koenbeuk merged commit 67e10a0 into master Mar 8, 2024
3 checks passed
@koenbeuk koenbeuk deleted the dotnet8 branch March 8, 2024 00:25
@PhenX
Copy link
Contributor

PhenX commented Mar 8, 2024

Hello @koenbeuk , good thing to update to dotnet 8, but dotnet 6 is not dead yet. Would it be possible to keep it? I know unit tests were changed and will be failing on dotnet 6, but maybe that's not an issue, as you could target only dotnet 8 for them.
We've been waiting for a new release with recent fixes, that would be sad if we could not upgrade our few projects still on dotnet 6 😥
Thank you again!

@koenbeuk
Copy link
Owner Author

@PhenX dotnet 8 is tied to V4 of this project. V3 can be maintained with dotnet 6 in mind. I will prep a release for both

@leoerlandsson
Copy link

Any update here? Is there .NET 8 support?

Can we help in any way?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants