Skip to content

Commit

Permalink
Merge pull request #902 from AllenShen/release-1.8.0
Browse files Browse the repository at this point in the history
fix secret bug
  • Loading branch information
flyer103 authored Jan 7, 2022
2 parents 0f2e823 + 2159d45 commit ed30b48
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2307,7 +2307,7 @@ func installOrUpgradeHelmChartWithValues(namespace, valuesYaml string, renderCha
releaseutil.Reverse(hrs, releaseutil.SortByRevision)
rel := hrs[0]
if rel.Info.Status == helmrelease.StatusPendingInstall || rel.Info.Status == helmrelease.StatusPendingUpgrade {
secretName := fmt.Sprintf("sh.helm.release.v1.%s.v.%d", rel.Name, rel.Version)
secretName := fmt.Sprintf("sh.helm.release.v1.%s.v%d", rel.Name, rel.Version)
deleteErr := updater.DeleteSecretWithName(rel.Namespace, secretName, kubecli)
if deleteErr != nil {
err = errors.WithMessagef(err, "failed to deleteSecretWithName:%s,error:%s", secretName, deleteErr)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ func (p *DeployTaskPlugin) Run(ctx context.Context, pipelineTask *task.Task, _ *
releaseutil.Reverse(hrs, releaseutil.SortByRevision)
rel := hrs[0]
if rel.Info.Status == helmrelease.StatusPendingInstall || rel.Info.Status == helmrelease.StatusPendingUpgrade {
secretName := fmt.Sprintf("sh.helm.release.v1.%s.v.%d", rel.Name, rel.Version)
secretName := fmt.Sprintf("sh.helm.release.v1.%s.v%d", rel.Name, rel.Version)
deleteErr := updater.DeleteSecretWithName(rel.Namespace, secretName, p.kubeClient)
if deleteErr != nil {
err = errors.WithMessagef(err, "failed to deleteSecretWithName:%s,error:%s", secretName, deleteErr)
Expand Down

0 comments on commit ed30b48

Please sign in to comment.