quick fix for random deletion for service revision

Signed-off-by: Min Min <[email protected]>
koderover · Apr 22, 2024 · 2cabaa4 · 2cabaa4
1 parent 08d2de7
commit 2cabaa4
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/pkg/microservice/aslan/core/service/service/helm.go b/pkg/microservice/aslan/core/service/service/helm.go
@@ -470,6 +470,9 @@ func prepareChartTemplateData(templateName string, logger *zap.SugaredLogger) (*
 }
 
 func getNextServiceRevision(productName, serviceName string, isProductionService bool) (int64, error) {
+	if serviceName == "" {
+		return 0, fmt.Errorf("service name cannot be empty")
+	}
 	rev, err := commonutil.GenerateServiceNextRevision(isProductionService, serviceName, productName)
 	if err != nil {
 		log.Errorf("Failed to get next revision for service %s, err: %s", serviceName, err)