Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Move Download button #11372

Merged
merged 4 commits into from
Jan 23, 2025
Merged

fix: Move Download button #11372

merged 4 commits into from
Jan 23, 2025

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
image image

@Jarsen136 Jarsen136 requested a review from a team as a code owner January 21, 2025 19:03
@Jarsen136 Jarsen136 requested review from preschian and hassnian and removed request for a team January 21, 2025 19:03
@netlify Netlify
Copy link

netlify bot commented Jan 21, 2025 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 8084797
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6790d27d63371a000887b4f5
😎 Deploy Preview https://deploy-preview-11372--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

preschian
preschian approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjust test? otherwise lgtm

hassnian
hassnian approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM

@hassnian hassnian added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Jan 22, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Jarsen136
Copy link
Contributor Author

adjust test? otherwise lgtm

Fixed

@vikiival vikiival added this pull request to the merge queue Jan 23, 2025
Merged via the queue into kodadot:main with commit 0492623 Jan 23, 2025
26 checks passed
@JustLuuuu
Copy link
Member

love it, thx @Jarsen136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hassnian hassnian hassnian approved these changes

@preschian preschian preschian approved these changes

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Download button
5 participants
@Jarsen136 @JustLuuuu @preschian @hassnian @vikiival