Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always push 'next' to the route handler fn args #8

Merged
merged 4 commits into from
Mar 5, 2014
Merged

Conversation

soygul
Copy link
Contributor

@soygul soygul commented Mar 4, 2014

This will make it possible to yield downwards even inside a handled route, like:

  app.use(route.get('/test/:param', function *(param, next) {
    // ...
    yield next;
  }));

@tj
Copy link
Member

tj commented Mar 4, 2014

LGTM but a test would be great

@soygul
Copy link
Contributor Author

soygul commented Mar 5, 2014

Didn't update the example in the readme not to spoil the simplicity of the example

tj added a commit that referenced this pull request Mar 5, 2014
always push 'next' to the route handler fn args
@tj tj merged commit 6bad4c7 into koajs:master Mar 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants