feat: add support to 'sometimes' rule #958
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I added the support for the "sometimes" validator rule that allow to skip all following validators like "required".
Currently, a field with this following rules was consired as required (but it shouldn't) :
'consent_cgu' => 'sometimes|accepted'
'other_field' => 'sometimes|required|...'
("filled" rule seems better for this case but "filled_if", "filled_with", ... not existing so it's not an universal solution).It notably fix this issue without any change to follow Laravel behaviour : #343
As Laravel behaviour, the following rules is correctly returned as required :
'badrule'=> 'required|sometimes|...'
Best regard