Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf] cache GamePadCapabilities #1630

Merged
merged 1 commit into from
May 27, 2024
Merged

[perf] cache GamePadCapabilities #1630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions MonoGame.Framework/Input/.SDL2/ConcreteGamePad.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ public sealed class ConcreteGamePad : GamePadStrategy
private class SdlGamePadDevice : GamePadDevice
{
public IntPtr Handle;
public GamePadCapabilities Capabilities;
public int PacketNumber;

public SdlGamePadDevice(IntPtr handle)
Expand Down Expand Up @@ -89,6 +90,7 @@ internal void AddDevice(int deviceIndex)
index++;

SdlGamePadDevice sdlGamepad = new SdlGamePadDevice(handle);
sdlGamepad.Capabilities = InternalGetCapabilities(handle);

_gamepads.Add(index, sdlGamepad);

Expand Down Expand Up @@ -139,22 +141,18 @@ public override int PlatformGetMaxNumberOfGamePads()
public override GamePadCapabilities PlatformGetCapabilities(int index)
{
if (_gamepads.TryGetValue(index, out SdlGamePadDevice sdlGamepad))
{
return InternalGetCapabilities(sdlGamepad.Handle);
}
else
{
return base.CreateGamePadCapabilities(
gamePadType: GamePadType.Unknown,
displayName: null,
identifier: null,
isConnected: false,
buttons: (Buttons)0,
hasLeftVibrationMotor: false,
hasRightVibrationMotor: false,
hasVoiceSupport: false
);
}
return sdlGamepad.Capabilities;

return base.CreateGamePadCapabilities(
gamePadType: GamePadType.Unknown,
displayName: null,
identifier: null,
isConnected: false,
buttons: (Buttons)0,
hasLeftVibrationMotor: false,
hasRightVibrationMotor: false,
hasVoiceSupport: false
);
}

private GamePadCapabilities InternalGetCapabilities(IntPtr handle)
Expand Down
Loading