[perf] discard VertexBuffer in SpriteBatcher

kniEngine · May 30, 2024 · d496211 · d496211
1 parent 86aaa3c
commit d496211
Showing 1 changed file with 16 additions and 2 deletions.
diff --git a/MonoGame.Framework/Graphics/.Common/SpriteBatcher.cs b/MonoGame.Framework/Graphics/.Common/SpriteBatcher.cs
@@ -53,6 +53,8 @@ internal sealed class SpriteBatcher : SpriteBatcherStrategy
         private DynamicVertexBuffer _vertexBuffer;
         private IndexBuffer _indexBuffer;
 
+        SetDataOptions _defaultVertexBufferSetDataMode = SetDataOptions.NoOverwrite;
+
         public override int BatchItemCount { get { return _batchItemCount; } }
 
         public SpriteBatcher(GraphicsDevice device, int capacity = 0)
@@ -71,6 +73,17 @@ public SpriteBatcher(GraphicsDevice device, int capacity = 0)
                 _batchItemList[i] = new SpriteBatchItem();
 
             EnsureArrayCapacity(capacity);
+
+            switch (_device.Adapter.Backend)
+            {
+                case GraphicsBackend.OpenGL:
+                case GraphicsBackend.GLES:
+                case GraphicsBackend.WebGL:
+                    // NoOverwrite is not implemented in GL.
+                    _defaultVertexBufferSetDataMode = SetDataOptions.Discard;
+                    break;
+            }
+
         }
 
         /// <summary>
@@ -208,8 +221,9 @@ public unsafe override void DrawBatch(Effect effect)
                 {
                     VertexPositionColorTexture* vertexArrayPtr = vertexArrayFixedPtr;
 
-                    SetDataOptions mode = SetDataOptions.NoOverwrite;
-                    if ((_baseQuad + numBatchesToProcess) * 4 > _vertexBuffer.VertexCount)
+                    SetDataOptions mode = _defaultVertexBufferSetDataMode;
+                    if (mode == SetDataOptions.Discard
+                    || (_baseQuad + numBatchesToProcess) * 4 > _vertexBuffer.VertexCount)
                     {
                         mode = SetDataOptions.Discard;
                         _baseQuad = 0;