Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pay-per-use description in homepage #6203

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix pay-per-use description in homepage #6203

wants to merge 1 commit into from
+1 −1

Conversation

guzalv
Copy link

@guzalv guzalv commented Jan 24, 2025

"meaning that companies only use what they pay for" -> "meaning that companies only pay for what they use".

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 24, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: guzalv / name: Guzman (ed66fd0)

@knative-prow knative-prow bot requested review from mmejia02 and skonto January 24, 2025 11:46
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 24, 2025

Welcome @guzalv! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 24, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 24, 2025 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ed66fd0
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6797f1a55241bc0008b5e7f3
😎 Deploy Preview https://deploy-preview-6203--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dprotaso
Copy link
Member

/assign @Leo6Leo @Cali0707 (eventing book store app)

Cali0707
Cali0707 suggested changes Jan 27, 2025
View reviewed changes
code-samples/eventing/bookstore-sample-app/start/node-server/config/100-deployment.yaml Outdated
@@ -29,6 +29,6 @@ spec:
app: node-server
ports:
- protocol: TCP
port: 80
port: 8080
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't seem relevant to this PR, can you remove it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Done, thanks!

docs/bookstore/page-0.5/environment-setup.md Outdated Show resolved Hide resolved
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: guzalv
Once this PR has been reviewed and has the lgtm label, please ask for approval from cali0707. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 requested changes

@mmejia02 mmejia02 Awaiting requested review from mmejia02

@skonto skonto Awaiting requested review from skonto

Assignees

@Cali0707 Cali0707

Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guzalv @dprotaso @Cali0707