Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed border radius on home page button #6168

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

AmanSarraf
Copy link
Contributor

"Fixes #6161

Proposed Changes

  • Changed button radius from 0.7rem to 8px
  • The roundness of the button does not looks much harsh

Before

image

After

image

@knative-prow knative-prow bot requested review from Leo6Leo and skonto November 27, 2024 15:56
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 27, 2024
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6d93e02
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6747413d3d0a550008d8e6cf
😎 Deploy Preview https://deploy-preview-6168--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Leo6Leo
Copy link
Member

Leo6Leo commented Nov 27, 2024

/lgtm
/approve
Thanks for the PR! @AmanSarraf

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
Copy link

knative-prow bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AmanSarraf, Leo6Leo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2024
@knative-prow knative-prow bot merged commit 8e73d5b into knative:main Nov 27, 2024
19 checks passed
@AmanSarraf AmanSarraf deleted the fixbutton branch November 28, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Button Roundness
2 participants