Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

responsive styling for case study section on Home page #6065

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

ShravaniAK
Copy link
Contributor

I have made the case study section on Home page responsive on all devices .

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 22, 2024
@knative-prow knative-prow bot requested review from ReToCode and skonto July 22, 2024 11:55
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 973f99b
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/66c70d9de6fe69000811dd94
😎 Deploy Preview https://deploy-preview-6065--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ShravaniAK
Copy link
Contributor Author

/cc @Cali0707 @zainabhusain227 @aliok

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 7, 2024
@ShravaniAK
Copy link
Contributor Author

I have worked on the feedback that was received during the UX meet,

  1. in mobile view, made the card wider
  2. also in the mobile view aligned the text in the center

@Cali0707
Copy link
Member

Cali0707 commented Aug 7, 2024

@ShravaniAK thank you for the changes, we will try and do a final review tomorrow in the UX meeting

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2024
@Leo6Leo
Copy link
Member

Leo6Leo commented Aug 8, 2024

The PR is approved during the UX WG meeting. But please fix the merging conflict before we proceed. Thank you for the great work @ShravaniAK

@Cali0707
Copy link
Member

Hey @ShravaniAK can you fix the merge conflicts so that we can merge this?

@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 22, 2024
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2024
Copy link

knative-prow bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, ShravaniAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2024
@knative-prow knative-prow bot merged commit f94c9f9 into knative:main Aug 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants