Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home page new design implementation #6041

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

ShravaniAK
Copy link
Contributor

issue #6040

changes made :

  1. replaced the svg for "Why serverless containers" section .
  2. aligned the text to center of "Knative Components" section.
  3. replaced the svg for "Trying it all together" section

@knative-prow knative-prow bot requested review from Leo6Leo and zainabhusain227 July 4, 2024 07:47
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 4, 2024
Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fa84f42
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/668d040ed40b7c000852d4ab
😎 Deploy Preview https://deploy-preview-6041--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ShravaniAK
Copy link
Contributor Author

/cc @Cali0707 @aliok

@knative-prow knative-prow bot requested review from aliok and Cali0707 July 4, 2024 07:47
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShravaniAK when I hover over the SVGs in the "why serverless containers" section, the text seems to be shifted down. Would you be able to fix this?

@ShravaniAK
Copy link
Contributor Author

hey @Cali0707 , I have fixed the hovering issue over the SVGs, and also did some minor styling fixes.

@ShravaniAK ShravaniAK requested a review from Cali0707 July 9, 2024 09:35
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@mmejia02 @zainabhusain227 can one of you review this and add an lgtm if it looks good to you?

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
Copy link

knative-prow bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, ShravaniAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2024
@knative-prow knative-prow bot merged commit e60ba5b into knative:main Jul 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants