-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
home page new design implementation #6041
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShravaniAK when I hover over the SVGs in the "why serverless containers" section, the text seems to be shifted down. Would you be able to fix this?
hey @Cali0707 , I have fixed the hovering issue over the SVGs, and also did some minor styling fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@mmejia02 @zainabhusain227 can one of you review this and add an lgtm if it looks good to you?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, ShravaniAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue #6040
changes made :