Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented the new case study section of the home page #6032

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

ShravaniAK
Copy link
Contributor

Fixes #6031

implemented the new design of the case study section , did the following changes

  1. changed the background color of each case study to white.
  2. changed the font family and removed the italic style.
  3. added margin and padding .
  4. Changed the color of the horizontal line and the font.
  5. added box shadow effect on Hover .

Before :
Screenshot 2024-06-28 at 2 40 41 PM

After:
Screenshot 2024-06-28 at 2 40 55 PM

@knative-prow knative-prow bot requested review from Cali0707 and Leo6Leo June 28, 2024 09:18
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 28, 2024
Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f9950b7
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/66993b1b87960c00086643ff
😎 Deploy Preview https://deploy-preview-6032--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Cali0707
Copy link
Member

/cc @zainabhusain227 @mmejia02

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2024
@Cali0707
Copy link
Member

Cali0707 commented Jul 9, 2024

Hey @zainabhusain227 @mmejia02 when you have some time can you compare the preview to the designs and leave any feedback here?

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ShravaniAK , feedback on these changes from todays UX WG review was:

  1. There should be a larger padding at the top of the case study boxes so that there is a bit more space between the company logo and the border of the box
  2. There should be more space between the "Knative is a Cloud Native Computing Foundation incubation project" text and the "Case Studies" section
  3. For the hover effect on the individual case studies, we should only change the border colour, and not do any box shadow. We should also add a transition to this so that it animates nicely
  4. The entire case study box should use the pointer for the mouse, and should be clickable and take users to the case study page. Currently, this only works if users click on the text in the box.
  5. We should incorporate the arrows from the design in Improvements to Case Studies Section ux#146

Thanks for all your work on this so far, once we have these fixes this should be good to merge

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 12, 2024
@ShravaniAK
Copy link
Contributor Author

@Cali0707 , I have implemented all the changes requested, except for the "incorporate the arrows" , I think that it's a new feature implementation that can be made in a new separate pr.

@ShravaniAK
Copy link
Contributor Author

Also for point 2 , I have fixed that in #6036

@ShravaniAK ShravaniAK requested a review from Cali0707 July 17, 2024 06:18
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2024
@Cali0707
Copy link
Member

@ShravaniAK it looks like this has some conflicts now that your other PR merged, would you mind fixing those?

@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2024
@ShravaniAK
Copy link
Contributor Author

@Cali0707 I have fixed the conflicts!

@Cali0707
Copy link
Member

Thanks @ShravaniAK ! There are a few issues that need fixing (see video below):

  1. When hovering over a case study, some of the text is shifted by the border
  2. The transition between no border and border should be animated
Screencast.from.2024-07-18.11-45-07.mp4

@ShravaniAK
Copy link
Contributor Author

@Cali0707 I have fixed both the issues, can you please review them once again, Thanks!

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @ShravaniAK !

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2024
Copy link

knative-prow bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, ShravaniAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024
@knative-prow knative-prow bot merged commit 3d8f6b2 into knative:main Jul 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement the case study section of the home page .
3 participants