Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove as_updated field in rss plugin #6027

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Jun 26, 2024

It should be defaulting to False anyway. Otherwise we have "expected string got bool error".

https://guts.github.io/mkdocs-rss-plugin/configuration/#date_from_meta

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 26, 2024
@dsimansk
Copy link
Contributor Author

/cc @matzew

@knative-prow knative-prow bot requested review from Cali0707, csantanapr and matzew June 26, 2024 08:09
Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 920ed6e
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/667bccabd113fb000895700e
😎 Deploy Preview https://deploy-preview-6027--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

ship it!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
Copy link

knative-prow bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 8e559a9 into knative:main Jun 26, 2024
19 checks passed
@dsimansk dsimansk deleted the pr/fix-rss-plugin branch June 26, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants