Adding apache camel k blog post #5992
Conversation
knative-prow
bot
added
the
size/M
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Matthias Wessendorf <[email protected]>
matzew
force-pushed
the
add_camel_k_eventing
branch
from
db7059d to
0e63c95
Compare
|
close, reopen, since CLA check was wrongly failing |
There was a problem hiding this comment.
Great to have a blog about this! 💪
Left some comments. Maybe you can also change from "we" to "you" (https://github.com/knative/docs/blob/main/contribute-to-docs/style-guide/voice-and-language.md#address-the-reader-as-you-not-we) 🤷
| kind: Kamelet | ||
| apiVersion: camel.apache.org/v1 | ||
| name: timer-source | ||
| properties: |
There was a problem hiding this comment.
Maybe you add a quick note, that the properties field is specific for the referenced kind (from .spec.source.ref). As you later use the same for the Trigger filter (line 81 & 82)
There was a problem hiding this comment.
I have a sentence below that example.
Co-authored-by: David Simansky <[email protected]>
Co-authored-by: David Simansky <[email protected]>
Co-authored-by: Christoph Stäbler <[email protected]>
Co-authored-by: Christoph Stäbler <[email protected]>
Co-authored-by: Christoph Stäbler <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
knative-prow
bot
added
size/L
| properties: | ||
| type: com.corp.my.timer.source |
There was a problem hiding this comment.
Is this necessary for a "sink" ?
There was a problem hiding this comment.
no, it is optional, w/o that it has a different CloudEvent type (org.apache....)
there is a bug in camel k, when reading from the broker. one MUST use proerties.type
There was a problem hiding this comment.
this is sink though? isn't it using the given type already ?
There was a problem hiding this comment.
ah, sorry. I did not see which you commented on. This is (currently) required. I have filed a bug w/ them, last week
Co-authored-by: David Simansky <[email protected]>
|
/approve /hold for other reviews |
knative-prow
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
@matzew one highlight idea. IMO it's a good candidate to add to "Featured Posts" section to promote it a bit more. I'd put it just below 1.14 release blog post. WDYT? |
Signed-off-by: Matthias Wessendorf <[email protected]>
|
/lgtm |
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
Proposed Changes