Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linux foundation trademark #5830

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Add linux foundation trademark #5830

merged 2 commits into from
Feb 2, 2024

Conversation

ReToCode
Copy link
Member

Proposed Changes

  • Add Linux Foundation trademark link
  • Fix cookie-banner link (no need to route it to pre-release any more)

Fixes #5829

/assign @knative/steering-committee
/assign @knative/technical-oversight-committee

@netlify Netlify
Copy link

netlify bot commented Jan 25, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3c70e9a
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/65b25c59cd8bd40008b4905a
😎 Deploy Preview https://deploy-preview-5830--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2024
@knative-prow knative-prow bot requested review from pmbanugo and skonto January 25, 2024 06:59
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 25, 2024
psschwei
psschwei reviewed Jan 25, 2024
View reviewed changes
overrides/partials/footer.html
<a href="https://policies.google.com/privacy">Privacy Policy</a> |
<a href="/development/about-analytics-cookies/">Cookie Usage</a> |
<a href="/docs/about-analytics-cookies/">Cookie Usage</a> |
Copy link
Contributor

@psschwei psschwei Jan 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also update this link on L113 and L124 below (in the cooke banner)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

psschwei
psschwei reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold
in case this needs more approvals (steering?), feel free to remove as you see fit

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2024
@krsna-m
Copy link
Contributor

krsna-m commented Jan 25, 2024

/lgtm

@ReToCode
Copy link
Member Author

ReToCode commented Jan 26, 2024 •
edited
Loading

in case this needs more approvals (steering?), feel free to remove as you see fit

I'm not sure, but as this is related to trademarks, better to have them.

PTAL @salaboy @aliok @puerco @evankanderson @nainaz

@ReToCode
Copy link
Member Author

Gentle ping @salaboy @aliok @puerco @evankanderson @nainaz

@aliok
Copy link
Member

aliok commented Feb 2, 2024

/lgtm
/approve
/unhold

Knative is already under CNCF (and Linux Foundation), so I will simply unhold this PR as we're only adding a link here.

Thanks Reto!

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, psschwei, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ReToCode,aliok,psschwei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit de4f35f into knative:main Feb 2, 2024
19 checks passed
prushh pushed a commit to prushh/docs that referenced this pull request Apr 30, 2024
@ReToCode @prushh
Add linux foundation trademark (knative#5830)
3b3e6e7 
* Add linux foundation trademark

* Update cookie banner url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei left review comments

@pmbanugo pmbanugo Awaiting requested review from pmbanugo

@skonto skonto Awaiting requested review from skonto

Assignees

@aliok aliok

@psschwei psschwei

@krsna-m krsna-m

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Website does not have the correct trademark disclaimer
4 participants
@ReToCode @krsna-m @aliok @psschwei