Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved passage titles out of pseudo-elements #3

Closed
wants to merge 2 commits into from

Conversation

ChapelR
Copy link

@ChapelR ChapelR commented Jan 26, 2020

fixes #1

Note: It appears the CSS that unhides <tw-storydata> was added to format.html and not source.html. I only realized that now, so this version unhides the element via JS instead. Whoops. I don't think it matters anyway.

@ChapelR
Copy link
Author

ChapelR commented May 29, 2020

I know you're busy, but I figured I'd bump this in case you hadn't seen it yet.

@klembot klembot closed this Jun 11, 2020
@ChapelR
Copy link
Author

ChapelR commented Jun 12, 2020

I still think making the passage titles printable/selectable with copy/paste is something Paperthin needs. If you have any suggestions on how I can improve this PR or notes on how you'd like to see it approached I'm all ears and I'm still willing to write the code if you don't have the time. I think this was closed because you changed the base branch.

@ChapelR
Copy link
Author

ChapelR commented Oct 23, 2020

I just remembered this as someone recently had an issue not being able to copy/paste titles on the subreddit. I don't have any way I'm aware of to re-open this from my end. I'm not sure how or if you want to proceed on this. The simplest thing, I believe, would be for me to just open a new PR doing the same thing again.

@klembot
Copy link
Owner

klembot commented Oct 25, 2020

I still would like to explore using poof or a mini version of poof as the proofing format in 2.4. If that doesn't turn out to work out, we can revisit this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could passage titles be made selectable?
2 participants