Skip to content
This repository has been archived by the owner on Nov 2, 2020. It is now read-only.

refactor(extension): improve code quality #23

Merged
merged 10 commits into from
Apr 8, 2018
Merged

refactor(extension): improve code quality #23

merged 10 commits into from
Apr 8, 2018

Conversation

kiyui
Copy link
Owner

@kiyui kiyui commented Apr 7, 2018

Refactor code to be cleaner & easier to maintain

Changed proposed:

  • Relint with standard
  • Rename SliderMenuItem to NightLightSlider
  • Refactor NightLightSlider such that NightLightExtension handles view updates and non-slider update on proxy g-properties-changed signal
  • Abstract updating night light schedule to a NightLightSchedule class that is in turn handled by NightLightExtension
  • Use GLib.timeout_add instead of the deprecated Mainloop function
  • Use standard for linting
  • Replace makefile build tools with npm

To-do:

Testing:

  • Change min & max feature working
  • Can status icon feature working
  • Show always feature working
  • Enable always feature with schedule update is working

@kiyui
Copy link
Owner Author

kiyui commented Apr 7, 2018

Refactored extension, for testing purposes: [email protected]

@kiyui kiyui merged commit aabff45 into master Apr 8, 2018
@kiyui kiyui deleted the refactor branch April 8, 2018 16:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant