This repository has been archived by the owner on Nov 2, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code to be cleaner & easier to maintain
Changed proposed:
standard
SliderMenuItem
toNightLightSlider
NightLightSlider
such thatNightLightExtension
handles view updates and non-slider update on proxyg-properties-changed
signalNightLightSchedule
class that is in turn handled byNightLightExtension
GLib.timeout_add
instead of the deprecatedMainloop
functionstandard
for lintingmakefile
build tools withnpm
To-do:
standard
topackage.json
and handle withprecommit
hookicon
instance so can support Change slider when scrolling with the mouse over the battery icon? #17 in the futureadd to menu
logic to support multiple item placements, such as Move slider to "Night Light On" submenu #22NightLightSlider
change event to support Show value on change #18disable
Testing:
min
&max
feature working