use basic auth, if no JWT token given #388
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if JWT Token, send it in header use X-JWT-Assertion as default header name if both (basic auth and JWT) given, use basic auth and add JWT Token via header ToDo: JWT Token validation
ChristianGeie
added
enhancement
disabling signature check if JWT token is valid, add it to header if JWT token is invalid only use basic auth
modify log messages add log message regards used JWT headername
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if JWT Token, send it in header
use X-JWT-Assertion as default header name
if both (basic auth and JWT) given, use basic auth and add JWT Token via header
ToDo: JWT Token validation