Add Playroom integration #4576
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. Out of curiosity, do you know if there is any possibility of customizing the Playroom UI a little bit? Adding an orbit header, palette, etc. Not critical of course. There was a problem hiding this comment. I have never tried, but I recall seeing someone asking about it. I did not read through because I was looking for an answer on something else, though 😅 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| const path = require("path"); | ||
| const { defaultFoundation } = require("@kiwicom/orbit-design-tokens"); | ||
|
|
||
| module.exports = { | ||
| title: "Orbit Playroom", | ||
| components: require.resolve("./playroomComponents.tsx"), | ||
| outputPath: "./.playroom/playroom", | ||
| frameComponent: "./playroom/FrameComponent.tsx", | ||
| snippets: "./playroom/snippets/index.ts", | ||
| scope: "./playroom/scope.ts", | ||
| port: 9000, | ||
| openBrowser: false, | ||
| widths: Object.values(defaultFoundation.breakpoint), | ||
| defaultVisibleWidths: [ | ||
| defaultFoundation.breakpoint.mediumMobile, | ||
| defaultFoundation.breakpoint.desktop, | ||
| ], | ||
| baseUrl: "/playroom/", | ||
| webpackConfig: () => ({ | ||
| resolve: { | ||
| extensions: [".js", ".jsx", ".ts", ".tsx", ".css"], | ||
|
There was a problem hiding this comment. Do we need .js* extensions? There was a problem hiding this comment. I believe playroom is actually checking for the built files, inside |
||
| modules: [ | ||
| "node_modules", | ||
| path.resolve(__dirname), | ||
| path.resolve(__dirname, "src"), | ||
| path.resolve(__dirname, "lib"), | ||
| path.resolve(__dirname, "node_modules"), | ||
| path.resolve(__dirname, "../.."), | ||
| ], | ||
| alias: { | ||
| "@kiwicom/orbit-components": path.resolve(__dirname), | ||
| }, | ||
| }, | ||
| module: { | ||
| rules: [ | ||
| { | ||
| test: /\.css$/i, | ||
| sideEffects: true, | ||
| exclude: /node_modules/, | ||
| use: [ | ||
| require.resolve("style-loader"), | ||
| require.resolve("css-loader"), | ||
| { | ||
| loader: require.resolve("postcss-loader"), | ||
| options: { | ||
| postcssOptions: { | ||
| plugins: [require.resolve("tailwindcss"), require.resolve("autoprefixer")], | ||
| }, | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| test: /\.(js|jsx|ts|tsx)$/, | ||
|
|
||
| exclude: /node_modules/, | ||
| use: { | ||
| loader: "babel-loader", | ||
| options: { | ||
| presets: ["@babel/preset-env", "@babel/preset-react", "@babel/preset-typescript"], | ||
| }, | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| }), | ||
| reactDocgenTypescriptConfig: { | ||
| // TODO: Disabling prop intellisense until we can fix the issue with correctly getting the props | ||
|
There was a problem hiding this comment. Have we created a ticket about this? There was a problem hiding this comment. No. I will create tickets for playroom improvements now |
||
| propFilter: () => false, | ||
| }, | ||
| exampleCode: ` | ||
| <div className="bg-white-normal p-300 h-screen"> | ||
| <Context> | ||
| {() => { | ||
| const [hasError, setHasError] = React.useState(false); | ||
|
|
||
| return ( | ||
| <Button | ||
| onClick={() => setHasError(!hasError)} | ||
| type={hasError ? "critical" : "primary"} | ||
| > | ||
| {hasError ? "Ups, click again" : "Click Me"} | ||
| </Button> | ||
| ); | ||
| }} | ||
| </Context> | ||
| </div> | ||
| `, | ||
| }; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we remove the playground logic? If so, will it be part of a different task?
In case we want to create a ticket.