feat(CountryFlag): add role prop for accessibility customization #4556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Deploying orbit with
|
| Latest commit: |
6f91065
|
| Status: | ⚡️ Build in progress... |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
|
Storybook staging is available at https://kiwicom-orbit-devin-1734607804-add-role-prop-countryflag.surge.sh |
|
Size Change: +13 B (0%) Total Size: 460 kB
ℹ️ View Unchanged
|
DSil
requested changes
Dec 19, 2024
devin-ai-integration
bot
force-pushed
the
devin/1734607804-add-role-prop-countryflag
branch
2 times, most recently
from
57e0fea to
b54435f
Compare
devin-ai-integration
bot
force-pushed
the
devin/1734607804-add-role-prop-countryflag
branch
from
b54435f to
dd6b7bc
Compare
mvidalgarcia
force-pushed
the
devin/1734607804-add-role-prop-countryflag
branch
from
dd6b7bc to
15cefcc
Compare
mvidalgarcia
approved these changes
Dec 19, 2024
Co-Authored-By: Jozef Képesi <[email protected]>
devin-ai-integration
bot
force-pushed
the
devin/1734607804-add-role-prop-countryflag
branch
from
15cefcc to
6f91065
Compare
mvidalgarcia
approved these changes
Dec 19, 2024
DSil
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added role prop to CountryFlag component to allow customizing the ARIA role of the underlying img element.
Link to Devin run: https://app.devin.ai/sessions/7f5e6966a6ab4b08a495ed623bc32d1b
✨
Description by Callstackai
This PR adds a
roleprop to theCountryFlagcomponent, allowing customization of the ARIA role for accessibility. It includes updates to types, documentation, and test coverage while maintaining backward compatibility.Diagrams of code changes
sequenceDiagram participant User participant CountryFlag participant Image User->>CountryFlag: Render with props (code, name, role) Note over CountryFlag: Default role="img" CountryFlag->>CountryFlag: Process country props CountryFlag->>Image: Render flag image Note over Image: Apply role attribute Image-->>User: Display flag with ARIA roleFiles Changed
roleprop with default value 'img' to the story.roleprop.role.CountryFlagcomponent to accept and apply theroleprop.roleprop.This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.md. See list of supported languages.