fix(HorizontalScroll): adjust arrows visibility when component is ove… #4533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook staging is available at https://kiwicom-orbit-sarka-horizontal-scroll-arrow-fix.surge.sh |
|
Size Change: -26 B (-0.01%) Total Size: 459 kB
ℹ️ View Unchanged
|
Deploying orbit with
|
| Latest commit: |
119d8e2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b9a3a155.orbit.pages.dev |
| Branch Preview URL: | https://sarka-horizontal-scroll-arro.orbit.pages.dev |
sarkaaa
force-pushed
the
sarka/horizontal-scroll-arrow-fix
branch
2 times, most recently
from
a353957 to
aecefeb
Compare
|
I tested changes in editor on docs page and also in Playground: |
sarkaaa
commented
Nov 27, 2024
sarkaaa
commented
Nov 27, 2024
| @@ -20,6 +19,35 @@ const getSnap = (scrollSnap: ScrollSnap) => { | |||
| return scrollSnap; | |||
| }; | |||
|
|
|||
| const getTriggerOffset = (spacing: string) => { | |||
There was a problem hiding this comment.
Tbh, I'm not sure if it's the best approach (probably not (?)), however, I needed to get the pixel value of set spacing and use this value as an integer for TRIGGER_OFFSET const. This value is used for computations in handleScroll functions, which is crucial for setting the visibility of arrow buttons.
I was (am) considering having this function in a specific file - the goal is to have it reusable in the future, but currently, it's used only within this file (and I don't know if it will be needed anywhere else one day), so I added it here.
|
I have tested with the code provided on the original request and noticed no change. Can you please confirm? |
DSil
reviewed
Nov 28, 2024
| @@ -76,6 +104,8 @@ const HorizontalScroll = React.forwardRef<HTMLDivElement, Props>( | |||
| const theme = useTheme(); | |||
| const scrollEl = scrollWrapperRef.current; | |||
|
|
|||
| const TRIGGER_OFFSET = getTriggerOffset(spacing); | |||
There was a problem hiding this comment.
All uppercase constants should be the same value every time, not calculated in runtime
| @@ -20,6 +19,35 @@ const getSnap = (scrollSnap: ScrollSnap) => { | |||
| return scrollSnap; | |||
| }; | |||
|
|
|||
| const getTriggerOffset = (spacing: string) => { | |||
There was a problem hiding this comment.
This completely changes the logic of the component, no? 🤔 the spacing was only for the space between elements. If you add it to the arrow positioning logic, it does not work...
Yours:
Prod:
sarkaaa
force-pushed
the
sarka/horizontal-scroll-arrow-fix
branch
3 times, most recently
from
fed7e3c to
bb5e2da
Compare
sarkaaa
force-pushed
the
sarka/horizontal-scroll-arrow-fix
branch
from
bb5e2da to
119d8e2
Compare
DSil
approved these changes
Nov 29, 2024
| @@ -11,8 +11,6 @@ import ChevronBackward from "../icons/ChevronBackward"; | |||
| import ChevronForward from "../icons/ChevronForward"; | |||
| import type { Props, ScrollSnap } from "./types"; | |||
|
|
|||
| const TRIGGER_OFFSET = 20; | |||
There was a problem hiding this comment.
I'm still curious why we added this in the first place and can't see any new glitch by removing it… So I guess it will have to work for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rflowing
This Pull Request meets the following criteria:
For new components:
d.tsfiles and are exported inindex.d.tsCloses https://kiwicom.atlassian.net/browse/FEPLT-1749