-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accessibility props to Heading #4516
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storybook staging is available at https://kiwicom-orbit-dsil-add-a11y-heading.surge.sh |
Size Change: +61 B (+0.01%) Total Size: 459 kB
ℹ️ View Unchanged
|
Deploying orbit with Cloudflare Pages
|
DSil
force-pushed
the
dsil/add-a11y-heading
branch
3 times, most recently
from
November 15, 2024 11:47
45dc7e6
to
465457a
Compare
sarkaaa
reviewed
Nov 17, 2024
sarkaaa
reviewed
Nov 18, 2024
DSil
force-pushed
the
dsil/add-a11y-heading
branch
from
November 18, 2024 08:47
465457a
to
165034f
Compare
sarkaaa
reviewed
Nov 18, 2024
sarkaaa
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
These props are added to enhance accessibility
DSil
force-pushed
the
dsil/add-a11y-heading
branch
from
November 19, 2024 14:06
165034f
to
d1907a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new props added
role
andlevel
. They're conditional props and allow to define the role and level of the rendered elements.The component also no longer automatically renders
role="heading"
when the rendered element is adiv
.FEPLT-2155