-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEPLT-2099 fix(ErrorFormTooltip): align text and cancel cross button #4460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storybook staging is available at https://kiwicom-orbit-sarka-fix-tooltip-alignement.surge.sh |
Size Change: 0 B Total Size: 459 kB
ℹ️ View Unchanged
|
Deploying orbit with Cloudflare Pages
|
sarkaaa
force-pushed
the
sarka/fix-tooltip-alignement
branch
2 times, most recently
from
August 23, 2024 12:15
702a892
to
e33e226
Compare
sarkaaa
changed the title
fix(ErrorFormTooltip): align text and cancel cross button
FEPLT-2099 fix(ErrorFormTooltip): align text and cancel cross button
Aug 23, 2024
DSil
approved these changes
Aug 26, 2024
I'd rewrite the commit to |
sarkaaa
force-pushed
the
sarka/fix-tooltip-alignement
branch
from
August 27, 2024 05:14
e33e226
to
aa18d7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request meets the following criteria:
For new components:
d.ts
files and are exported inindex.d.ts
Closes https://kiwicom.atlassian.net/browse/FEPLT-2099
Description: The original tooltip text had
line-height: 16px
, now it's20px
. Figma design (I hope I checked the correct one) contains this new20px
. Also, the change of line-height caused the size of the tooltip (in case it's one-line), I measured the height and it should correspond to the design now.