-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix padding on Tag in RTL #4434
Conversation
Storybook staging is available at https://kiwicom-orbit-domi-fix-tag-padding.surge.sh |
Size Change: -1 B (0%) Total Size: 445 kB
ℹ️ View Unchanged
|
@@ -89,7 +89,7 @@ const Tag = React.forwardRef<HTMLDivElement, Props>( | |||
onKeyDown={ev => buttonClickEmulation(ev, onClick)} | |||
> | |||
{iconLeft && ( | |||
<div className="pr-xs [&_svg]:size-icon-small flex flex-row items-center justify-center"> | |||
<div className="pe-xs [&_svg]:size-icon-small flex flex-row items-center justify-center"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
As this only affected the RTL version visually, I'd adjust the commit title to reflect this so that it would be more accurate for the consumers. I'll take care of this since Domi is off. |
898cbfd
to
de18d77
Compare
Closes https://kiwicom.atlassian.net/browse/FEPLT-2069