chore: update Storybook version #4407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook staging is available at https://kiwicom-orbit-domi-update-storybook.surge.sh |
|
Size Change: 0 B Total Size: 445 kB ℹ️ View Unchanged
|
Deploying orbit with
|
| Latest commit: |
9c1d46a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f7bbb1ff.orbit.pages.dev |
| Branch Preview URL: | https://domi-update-storybook.orbit.pages.dev |
domihustinova
force-pushed
the
domi/update-storybook
branch
4 times, most recently
from
b3df8e7 to
458ad29
Compare
domihustinova
commented
Jul 5, 2024
domihustinova
force-pushed
the
domi/update-storybook
branch
from
458ad29 to
9dd0820
Compare
domihustinova
commented
Jul 5, 2024
domihustinova
commented
Jul 8, 2024
domihustinova
force-pushed
the
domi/update-storybook
branch
11 times, most recently
from
d59655c to
8fa9de6
Compare
domihustinova
force-pushed
the
domi/update-storybook
branch
5 times, most recently
from
0b656fe to
8ef806d
Compare
domihustinova
force-pushed
the
domi/update-storybook
branch
2 times, most recently
from
99d7128 to
c06b2d7
Compare
DSil
reviewed
Jul 30, 2024
| }; | ||
| export const Default: Story = { | ||
| render: () => { | ||
| const [expandedSection, setExpandedSection] = React.useState("0X1"); |
There was a problem hiding this comment.
This is triggering linter warnings
While I understand this is more Storybook's fault, we should avoid it. We have two options:
- We ignore this rule for stories files
- We transform this arrow function into a proper function:
render: function Render() {…I don't particularly like any, but I think I debatably prefer the second.
There was a problem hiding this comment.
What arrow function do you mean? Was this fixed already?
There was a problem hiding this comment.
Yes, it's fixed. It used to be
render: () => {…}but if it had hooks inside (like React.useState) it would trigger that warning. Therefore, it needs to be
render: function Render() {…}| </Accordion> | ||
| ); | ||
| }; | ||
| export const Default: Story = { |
There was a problem hiding this comment.
If a story has no controls, like this one
We can do
parameters: {
controls: {
disable: true,
},
},and so the Controls tab won't show. I think it looks better. WDYT?
There was a problem hiding this comment.
Agree, it indeed looks better. I will add it to control-less stories 👍
domihustinova
force-pushed
the
domi/update-storybook
branch
from
c06b2d7 to
670e48d
Compare
mvidalgarcia
approved these changes
Aug 1, 2024
mvidalgarcia
force-pushed
the
domi/update-storybook
branch
from
670e48d to
9c1d46a
Compare
mvidalgarcia
approved these changes
Aug 1, 2024
DSil
approved these changes
Aug 1, 2024
This was referenced Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: update Storybook version
Update Storybook to latest version using the recommended
npx storybook@latest upgrade. This guide also addedgetAbsolutePathtomain.ts, which is now part of standard SB installation in a monorepo. Also followed migration guide and did further changes, e.g. replaced@storybook/addonswith@storybook/manager-apiwhich is now required.Since
Sourcedoc blocks is now not to be used in stories, I recreated the source component withprism-react-rendererwith copy to clipboard functionality.chore: replace deprecated addon-knobs with addon-controls
@storybook/addon-knobsis deprecated and being replaced with@storybook/addon-controls. I followed migration guide and refactored all stories to useargs. There were some cases when controlls weren't properly generated andargTypesannotations needed to be added. This was case for e.g.selectorrange.chore: replace deprecated addon-styling with addon-styling-webpack
@storybook/addon-stylingis also deprecated and replaced with two addons,@storybook/addon-styling-webpackand@storybook/addon-themes. I again followed migration guide to replace it.Rest of the commits is refactoring individual stories from CSF 2 to CSF 3 to add type validation to the props https://storybook.js.org/docs/api/csf#upgrading-from-csf-2-to-csf-3
Closes https://kiwicom.atlassian.net/browse/FEPLT-2048