-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ButtonLink): handle hover state on mobile #4403
Conversation
Size Change: +28 B (+0.01%) Total Size: 445 kB
ℹ️ View Unchanged
|
Storybook staging is available at https://kiwicom-orbit-domi-fix-buttonlink.surge.sh |
Deploying orbit with
|
Latest commit: |
a85de07
|
Status: | ✅ Deploy successful! |
Preview URL: | https://90eadf8a.orbit.pages.dev |
Branch Preview URL: | https://domi-fix-buttonlink.orbit.pages.dev |
I believe we should be doing this instead. |
Yes, I found this flag too but I wasn't sure if we want to use it as it's global setting so I used the solution we are already using in FilterWrapper. I can use the flag then 👌 |
9078709
to
d46129b
Compare
d46129b
to
a85de07
Compare
As we talked about offline, we'll keep the Tailwind classes with arbitrary values and add the Tailwind config commented out as a reference for the future. |
The reported issue was caused by the "sticky hover" issue on mobile devices. We weren't handling it for ButtonLink so I changed hover styles only when hover is applicable.
Closes FEPLT-2045