-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Icons IDs #4376
Merged
Merged
Replace Icons IDs #4376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storybook staging is available at https://kiwicom-orbit-dsil-icon-ids-generator.surge.sh |
Size Change: -1 B (0%) Total Size: 442 kB
ℹ️ View Unchanged
|
Deploying orbit with Cloudflare Pages
|
Randomly generated IDs were causing conflicts. We now rely on Figma IDs only
This was a result of applying the new id generator algorithm. No changes to icons, just changed the comment with the character id.
DSil
force-pushed
the
dsil/icon-ids-generator
branch
from
June 12, 2024 14:02
7bb0a0f
to
8743daa
Compare
mvidalgarcia
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Randomly generated IDs were causing conflicts. We now rely on Figma IDs only.
All the currently existing icons were also updated by running a one-off script (not included here) to just update the ID and not modify the svg content. Prettier was also applied to the resulting SVG.
After merging this, the failing Update Icons cronjob should be able to successfully detect and add the 4 updated icons, so it's something to look at after this is merged.