feat(Radio): update component visually to match latest Figma #4372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook staging is available at https://kiwicom-orbit-rcsl-update-radio-visually.surge.sh |
|
Size Change: +8 B (0%) Total Size: 442 kB
ℹ️ View Unchanged
|
Deploying orbit with
|
| Latest commit: |
2c5261a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://52fa7c9d.orbit.pages.dev |
| Branch Preview URL: | https://rcsl-update-radio-visually.orbit.pages.dev |
|
We need to update this picture as well. |
Could you elaborate on this? I think adding the Figma link in the PR description would help as well. |
It's in the Jira ticket so didn't think it'd be necessary to add the info here as well. (Actually, do you know why the Jira ticket wasn't picked up?) |
I ran the CI job to update snapshots but it seems to be taking a long time. |
Basically, the default border should be 1px-wide and only in some other cases it is 2px-wide. |
| @@ -64,18 +64,21 @@ const Radio = React.forwardRef<HTMLInputElement, Props>((props, ref) => { | |||
| "flex flex-none items-center justify-center", | |||
| "size-icon-medium rounded-full", | |||
| "duration-fast scale-100 transition-all ease-in-out", | |||
| "lm:border border-[2px] border-solid", | |||
| "lm:border border-solid", | |||
| checked ? "border-[2px]" : "border-[1px]", | |||
There was a problem hiding this comment.
On large mobile or greater and checked, lm:border takes preference over border-[2px] (mq specificity I assume), resulting in a 1px border when it should be 2px.
There was a problem hiding this comment.
Well spotted. There does not seem to be a responsive difference now, so I have adjusted the classes. I have also used the native border and border-2 tailwind classes, avoiding custom ones 🙂
"Resolves" vs "Closes" perhaps? |
How is this related to snapshots? I meant this image in orbit.kiwi https://orbit.kiwi/static/fdcbdae8f39964dc436131a8c0d06128/0d390/160%253A1219.png |
Yeah, also the focus state is currently greyish when it should be blue 
|
RobinCsl
force-pushed
the
rcsl/update-radio-visually
branch
from
18eeef9 to
c29ad91
Compare
DSil
reviewed
Jun 6, 2024
There was a problem hiding this comment.
Leftover from other PR, updated here for convenience
DSil
force-pushed
the
rcsl/update-radio-visually
branch
from
ec626fd to
6260a98
Compare
DSil
force-pushed
the
rcsl/update-radio-visually
branch
from
6260a98 to
23532b8
Compare
This still applies, I believe is the only thing left. |
The task was to only update the 'selected' state (both in 'normal' and 'disabled' states), but I noticed additional inconsistencies between Figma and the current state. Resolves FEPLT-2012
DSil
force-pushed
the
rcsl/update-radio-visually
branch
from
23532b8 to
7f6b105
Compare
DSil
force-pushed
the
rcsl/update-radio-visually
branch
from
7f6b105 to
2c5261a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task was to only update the 'selected' state (both in 'normal' and 'disabled' states), but I noticed additional inconsistencies between Figma and the current state.
Resolves FEPLT-2012
This Pull Request meets the following criteria:
For new components:
d.tsfiles and are exported inindex.d.ts