ci: add write-all to storybook permissions #4316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous setup failed on the push to master, as it only had write permissions on pull-requests
|
Storybook staging is available at https://kiwicom-orbit-ci-write-all-storybook.surge.sh |
|
Size Change: +2 B (0%) Total Size: 443 kB
ℹ️ View Unchanged
|
Deploying orbit with
|
| Latest commit: |
6328f18
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://696e42f5.orbit.pages.dev |
| Branch Preview URL: | https://ci-write-all-storybook.orbit.pages.dev |
|
Merging to allow unblocking of pipelines on master |
RobinCsl
reviewed
Mar 26, 2024
| @@ -16,8 +16,7 @@ env: # Set environment variables for every job and step in this workflow | |||
| jobs: | |||
| deploy: | |||
| runs-on: ubuntu-latest | |||
| permissions: | |||
| pull-requests: write # for dependabot | |||
| permissions: write-all # for dependabot | |||
There was a problem hiding this comment.
Would just adding pages: write be enough then?
There was a problem hiding this comment.
🤔 valid question. So you'd recommend pull-requests and pages, right? We can try it
There was a problem hiding this comment.
Yeah, I'd prefer the least privilege approach :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the merge of #4311 all master deploys of storybook were failing because one could not push to GH Pages, as the permissions only had write permissions on pull requests. This should bring those permissions back without affecting the dependabot