Remove unnecessary GH_TOKEN from publish job #4306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PAT token is enough to have the push rights.
|
Storybook staging is available at https://kiwicom-orbit-ci-remove-gh-token-from-publish.surge.sh |
|
Size Change: -5 B (0%) Total Size: 443 kB
ℹ️ View Unchanged
|
Deploying with
|
| Latest commit: |
3da53c6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cbb76eee.orbit.pages.dev |
| Branch Preview URL: | https://ci-remove-gh-token-from-publ.orbit.pages.dev |
RobinCsl
reviewed
Mar 14, 2024
| @@ -58,7 +58,6 @@ jobs: | |||
| if: ${{ github.event.inputs.dryrun == 'false' }} | |||
| env: | |||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} # must be of type Automation to create releases | |||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
There was a problem hiding this comment.
So secrets.PAT is used for the Checkout step in this file, but for the Publish step, there won't be any GitHub token set.
Is that because we have the permissions.contents = write at the beginning? In that case, is secrets.PAT really necessary?
There was a problem hiding this comment.
Also, GH_TOKEN is a Lerna specific env variable, IIRC. So if we don't have it defined anymore, it's not going to work. Right?
https://github.com/lerna/lerna/tree/main/libs/commands/version#--create-release-type
There was a problem hiding this comment.
The PAT used for checkout persists through the whole job. It is the bot's PAT so it has the push rights needed on this step.
As for Lerna using GH_TOKEN, that is interesting. And I guess you are right, indeed. We didn't realize nor mention it in the discussion thread. So I guess there is nothing to do here 🤔
There was a problem hiding this comment.
The PAT used for checkout persists through the whole job. It is the bot's PAT so it has the push rights needed on this step.
The CI job's PAT is actually available under secrets.GITHUB_TOKEN, no? I don't think it's available under PAT?
There was a problem hiding this comment.
Yes, but the commit and push must be authored by the bot. They can't rely on the CI job's PAT. So we basically need the bot's PAT for the commit and push and the GITHUB_TOKEN (provided by the job itself) to be used by Lerna. That is my understanding
|
As discussed IRL, nothing to do here. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PAT token is enough to have the push rights.
The branch protection rules for the master branch were also adjusted. We had @RobinCsl and @mvidalgarcia as exceptions but that is not needed since they're already admins.
FEPLT-1948