Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Wizard): migrate to tailwind #4285
feat(Wizard): migrate to tailwind #4285
Changes from all commits
03c3d92
e530e17
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a bit nitpick, but these hover and focus styles only applied on desktop and above. With this, this is being applied in tablet as well. I don't think there is a major problem, but I don't know how weird that effect might be on a touch device like a tablet.
To avoid any complications, and to keep 100% match, do you think you can add a desktop selector to these classes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think breakpoints smaller than desktop imply touch device. You can still have a small window even on a computer with pointer device. Thus I prefer not restricting
hover/focus
on specific media queries. But if you prefer 100% match I’ll tweak it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My point was more the opposite: if we only have it for desktop and above, it is very unlikely to have hover effects on a touch device. But for the sake of simplification I don't mind keeping your approach as is 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I follow but afaik the row timeline with hovers is visible from
lm:
and above. But anyway let’s keep it simple then 👍This file was deleted.