-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Accordion): migrate to tailwind #4277
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storybook staging is available at https://kiwicom-orbit-tw-accordion.surge.sh |
Size Change: -1.52 kB (0%) Total Size: 455 kB
ℹ️ View Unchanged
|
Deploying with Cloudflare Pages
|
vbulant
force-pushed
the
tw/accordion
branch
2 times, most recently
from
February 19, 2024 17:05
afd8a98
to
e087fbb
Compare
DSil
reviewed
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great, just some questions
packages/orbit-components/src/Accordion/components/AccordionWrapper/index.tsx
Outdated
Show resolved
Hide resolved
packages/orbit-components/src/Accordion/components/AccordionWrapper/index.tsx
Outdated
Show resolved
Hide resolved
packages/orbit-components/src/Accordion/components/AccordionWrapper/index.tsx
Outdated
Show resolved
Hide resolved
packages/orbit-components/src/Accordion/components/AccordionWrapper/index.tsx
Outdated
Show resolved
Hide resolved
vbulant
force-pushed
the
tw/accordion
branch
from
February 21, 2024 14:43
e087fbb
to
40bca2c
Compare
DSil
reviewed
Feb 22, 2024
packages/orbit-components/src/Accordion/AccordionSection/index.tsx
Outdated
Show resolved
Hide resolved
vbulant
force-pushed
the
tw/accordion
branch
from
February 22, 2024 09:24
40bca2c
to
1fee9ee
Compare
vbulant
commented
Feb 22, 2024
packages/orbit-components/src/Accordion/AccordionSection/components/SectionHeader.tsx
Show resolved
Hide resolved
DSil
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FEPLT-1699
This Pull Request meets the following criteria:
For Tailwind migrations:
- [ ] Visual regression test suite has been added if does not exist.(already exists)tailwind-migration-status.yaml
file has been updated with the migrated component(s).For new components:
d.ts
files and are exported inindex.d.ts