-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visual test updater job + fix visual tests #4276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSil
force-pushed
the
dsil/add-visual-tests-update-job
branch
from
February 19, 2024 16:21
35a1d84
to
cd19022
Compare
Deploying with Cloudflare Pages
|
DSil
force-pushed
the
dsil/add-visual-tests-update-job
branch
from
February 19, 2024 16:21
cd19022
to
da5ebe8
Compare
Storybook staging is available at https://kiwicom-orbit-dsil-add-visual-tests-update-job.surge.sh |
Size Change: 0 B Total Size: 457 kB
ℹ️ View Unchanged
|
DSil
force-pushed
the
dsil/add-visual-tests-update-job
branch
14 times, most recently
from
February 20, 2024 13:13
f7143df
to
b8894a1
Compare
Just one question: how did you trigger the new job? It looks good otherwise! |
@RobinCsl
just to try it. But then I deleted it. I'll add it on the PR description |
DSil
force-pushed
the
dsil/add-visual-tests-update-job
branch
from
February 21, 2024 09:26
b8894a1
to
aa8c05a
Compare
RobinCsl
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a job to manually update linux snapshots
Fixes Modal and CarrierLogo snapshots
For testing purposes, the yaml file temporarily had
so it triggered the job to update the snapshots (commit
chore: update visual tests
). I removed it because we want to run it manually.FEPLT-1949