Deploy playwright reports #4261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook staging is available at https://kiwicom-orbit-dsil-deploy-playwright-reports.surge.sh |
|
Size Change: +4 B (0%) Total Size: 458 kB
ℹ️ View Unchanged
|
Deploying with
|
| Latest commit: |
607f5cd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://91c0ca74.orbit.pages.dev |
| Branch Preview URL: | https://dsil-deploy-playwright-repor.orbit.pages.dev |
DSil
force-pushed
the
dsil/deploy-playwright-reports
branch
21 times, most recently
from
05bd782 to
38f0b33
Compare
mvidalgarcia
reviewed
Feb 8, 2024
mvidalgarcia
reviewed
Feb 9, 2024
DSil
force-pushed
the
dsil/deploy-playwright-reports
branch
2 times, most recently
from
7523f49 to
1582563
Compare
mvidalgarcia
reviewed
Feb 9, 2024
.github/workflows/test.yml
Outdated
| test-ct-report: | ||
| name: Visual Regression Tests Report | ||
| runs-on: ubuntu-latest | ||
| if: always() |
There was a problem hiding this comment.
I wonder if there's a cleaner way to run this job only when test-ct fails instead of always and do the checks inside.
Have you considered something like this? (untested)
if: ${{ needs.test-ct.result == 'failure' }}Disregard this comment if you find it so cumbersome, we can tackle this in future iterations.
There was a problem hiding this comment.
On the official docs, they recommend using always(). I have tried several other approaches and they all failed in some case. I did not try that one. I can give it a quick try
There was a problem hiding this comment.
So it works for when all tests pass. Will now test with failing tests
There was a problem hiding this comment.
This is cool, let's see 🤞
There was a problem hiding this comment.
As discussed IRL, if: ${{ always() && needs.test-ct.result == 'failure' }} does the trick. So we will go with that and the simplification of the run part, removing the verification for the artifacts existence
mvidalgarcia
reviewed
Feb 9, 2024
mvidalgarcia
reviewed
Feb 9, 2024
mvidalgarcia
reviewed
Feb 9, 2024
DSil
force-pushed
the
dsil/deploy-playwright-reports
branch
from
1582563 to
5f9d504
Compare
mvidalgarcia
approved these changes
Feb 9, 2024
DSil
force-pushed
the
dsil/deploy-playwright-reports
branch
3 times, most recently
from
03aa1f9 to
8d02386
Compare
This will remove the test report once the PR is closed
DSil
force-pushed
the
dsil/deploy-playwright-reports
branch
from
8d02386 to
607f5cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playwright reports are deployed with surge when visual tests fail.
On PR close, they are deleted.
I forced one Tag test to fail (on a now deleted commit), and it's possible to see the pipeline execution here. The tests fail and the report is deployed here.
If no tests fail, no report is deployed. Example here.
The deletion pipeline will be executed after this PR is merged (and will delete the report this generated).
FEPLT-1942