fix(Modal): fix border radius on isMobileFullPage #4258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook staging is available at https://kiwicom-orbit-marco-modal-hack.surge.sh |
|
Size Change: -35 B (0%) Total Size: 457 kB
ℹ️ View Unchanged
|
Deploying with
|
| Latest commit: |
5912976
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5d047af6.orbit.pages.dev |
| Branch Preview URL: | https://marco-modal-hack.orbit.pages.dev |
DSil
reviewed
Feb 6, 2024
| !hasModalSection && | ||
| "[&_.orbit-modal-header-container]:mb-xl lm:[&_.orbit-modal-header-container]:mb-[var(--orbit-modal-footer-height,0px)]", | ||
| !isMobileFullPage && "rounded-t-modal-mobile", |
There was a problem hiding this comment.
This can be on the second part of the ternary below, no?
|
Maybe we should have visual tests that assert this 😶🌫️ |
mvidalgarcia
force-pushed
the
marco/modal-hack
branch
6 times, most recently
from
3d15faa to
99dcff1
Compare
mvidalgarcia
force-pushed
the
marco/modal-hack
branch
3 times, most recently
from
9d19755 to
1ad7766
Compare
DSil
reviewed
Feb 15, 2024
| @@ -14164,28 +14164,6 @@ | |||
| "value": "rgb(186, 199, 213)" | |||
| } | |||
| }, | |||
| "modalBorderRadiusMobile": { | |||
There was a problem hiding this comment.
Unlike the tailwind package, a token deletion is a breaking change, even if it is just an internal token. I would just mark this as deprecated instead of removing it. We can (and should) do a cleanup of all the tokens soon™.
The tailwind class removal can be kept, as it is undocumented 👍
There was a problem hiding this comment.
Agree, updated.
And adjust modalBorderRadius to be 12px as stated in Figma.
Modal only has one borderRadius value and stays in 'modal'
'modal-mobile' classes are gone and we rely only on 'modal'
Screenshots updated with a uniform 12px border-radius.
mvidalgarcia
force-pushed
the
marco/modal-hack
branch
from
1ad7766 to
5912976
Compare
DSil
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://skypicker.slack.com/archives/C7T7QG7M5/p1707228421814789
Closes FEPLT-1947