-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: format generated tokens file #4257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storybook staging is available at https://kiwicom-orbit-dsil-format-tokens-json.surge.sh |
Size Change: 0 B Total Size: 459 kB ℹ️ View Unchanged
|
Deploying with Cloudflare Pages
|
DSil
force-pushed
the
dsil/format-tokens-json
branch
from
February 7, 2024 09:11
d09e070
to
cfc5df4
Compare
mvidalgarcia
reviewed
Feb 7, 2024
mvidalgarcia
approved these changes
Feb 7, 2024
DSil
force-pushed
the
dsil/format-tokens-json
branch
from
February 8, 2024 00:59
cfc5df4
to
70bd113
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tokens cronjob was failing because it was always trying to commit files that, in the end, were only modified by removing the empty line at EOF.
This empty line was added because the
fetch:colors
script generates the palette files every time, without formatting it with prettier rules, hence the absence of an empty line at EOF.Now we use prettier to format the document, avoiding false changes