-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace chromatic visual test with playwright #4232
Conversation
0ad6b4b
to
f016bf2
Compare
Deploying with Cloudflare Pages
|
Size Change: -2 B (0%) Total Size: 459 kB
ℹ️ View Unchanged
|
25a7356
to
303d232
Compare
...src/Accordion/Accordion.ct.tsx-snapshots/visual-Accordion-Stack-default-1-Desktop-darwin.png
Outdated
Show resolved
Hide resolved
...llustration.ct.tsx-snapshots/visual-Accordion-AirportIllustration-1-Medium-Mobile-darwin.png
Outdated
Show resolved
Hide resolved
...ponents/src/Button/Button.ct.tsx-snapshots/visual-Button-Button-default-1-Desktop-darwin.png
Outdated
Show resolved
Hide resolved
f29cd8f
to
fb4921e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1st pass of review
...dion/Accordion.ct.tsx-snapshots/visual-Accordion-Accordion-default-1-Small-Mobile-darwin.png
Outdated
Show resolved
Hide resolved
...nts/src/Accordion/Accordion.ct.tsx-snapshots/visual-Accordion-Accordion-1-Desktop-darwin.png
Outdated
Show resolved
Hide resolved
...rbit-components/src/Drawer/Drawer.ct.tsx-snapshots/visual-Drawer-Drawer-1-Desktop-darwin.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This screenshot doesn't seem to be generated by the tests, as it's printing all the Illustrations in one place.
...es/orbit-components/src/Modal/Modal.ct.tsx-snapshots/visual-Modal-Modal-1-Desktop-darwin.png
Outdated
Show resolved
Hide resolved
fb4921e
to
33f43b4
Compare
Could you please take a look at the pipeline? |
this should be solved when I will update linux screenshots |
b122393
to
6da6a24
Compare
6da6a24
to
b666527
Compare
Storybook staging is available at https://kiwicom-orbit-chore-cleanup-chromatic.surge.sh |
8791eea
to
3a8e1bc
Compare
test: update snapshots chore(ChoiceGroup): add linux screenshots chore(Modal): add linux screenshots chore(Illustration): add linux screenshots chore(CarrierLogo): add linux screenshots chore(Badge): add linux screenshots chore(Button): add linux screenshots chore(NotificationBadge): add linux screenshots chore(ButtonLink): add linux screenshots chore(ButtonMobileStore): add linux screenshots
4b7952d
to
89b6903
Compare
Replaced the tests to not lose the coverage we already had with chromatic. Although I mostly just moved Storybook stories under Playwright, so they are structured as before, it has the benefit that it produces fewer screenshots but still might need some polish later, but for now, it's better than nothing :)
FEPLT-1927
TODO
Storybook: https://orbit-mainframev-chore-cleanup-chromatic.surge.sh