Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright: add maxDiffPixels to playwright and --ignore-scripts flag #4218

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Playwright: add maxDiffPixels to playwright and --ignore-scripts flag #4218

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdb22eb
test: add maxDiffPixels to playwright and --ignore-scripts flag
DSil Jan 10, 2024
1fbfadd
chore: update vale config
DSil Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"tokens": "yarn workspace @kiwicom/orbit-design-tokens",
"tracking": "yarn workspace @kiwicom/orbit-tracking",
"update-supported-browsers": "markdown --path .github/contribution/testing-conventions.md && git add .github/contribution/testing-conventions.md",
"docker:reset": "rm -rf packages/orbit-components/playwright/.cache && yarn install --frozen-lockfile"
"docker:reset": "rm -rf packages/orbit-components/playwright/.cache && yarn install --frozen-lockfile --ignore-scripts"
},
"engines": {
"yarn": ">=1.19.1"
Expand Down
1 change: 1 addition & 0 deletions packages/orbit-components/playwright-ct.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export default defineConfig({
expect: {
toHaveScreenshot: {
threshold: 0.01, // default is 0.2 and that is way too lax, gives false negatives
maxDiffPixels: 10, // default is 0 and was causing problems with icons that were off by a single pixel
},
},
use: {
Expand Down
Loading